Forum



~Gast am 31.03.2021 11:39 #15704


Hi all!

I'm go to https://www.siedler25.org/index.php?com=dynamic&mod=81
and it's doesn't work;(


LordVader am 31.03.2021 11:49 #15705


You could try the in-game map generator. I think the output files are also compatible with the old S2 in case that is your intention :-)
If you're missing any features, let me know!


Flamefire am 31.03.2021 21:51 #15706


And what do you mean by "doesn't work"? It does work for me at least

---
Github: https://github.com/Flamefire


zagent am 01.04.2021 15:41 #15707


Does not respond to button presses.
It doesn't work at all.
It only worked when I started using a VPN.
Russia doesn't want me to generate maps;)


zagent am 01.04.2021 15:45 #15708


When I press Random map in the game, game crash. And message:

terminate called after throwing an instance of 'std::logic_error'
  what():  Invalid parameters given


Flamefire am 02.04.2021 11:04 #15709


Doesn't happen here, please use the latest nightly.

---
Github: https://github.com/Flamefire


ahasver am 02.04.2021 20:09 #15710


The generator on the portal works fine - period.

LordVader wrote:
You could try the in-game map generator.
I think the output files are also compatible with the old S2 in case that is your intention :-)
If you're missing any features, let me know!

The in-game generator produces very nice HUGE maps (Random.swd) and saves them in:
     C:/Users/Admin/Saved Games/Return To The Roots/MAPS
These maps are executable in s25client - without problems.
BUT:
People tend to modify/improve things they haven't produced themselves.
So, after shifting the Random.swd to > C:/Spiele/RttR/s25rttr_20210317/WORLDS < and invoking S25EDIT,
the attempt of loading the map was answered by the editor per logfile:
     Loading palette from file: GFX/PALETTE/PAL5.BBM...Error while reading:
     "C:/Spiele/RttR/s25rttr_20210317/WORLDS/Random.swd": Read failed at line 696
This happened independent of map-size (tiny/huge); .swd's of any other provenience were loaded without any issue.
So - no compatibility with s25edit, not to speak of S2 / S2EDIT !!
I hope very much this can be fixed! By the way - it would be very convenient,
if the map would be stored directly in WORLDS instead of that odd place UsersAdmin ...

regards

---
28.03.1948 - Osterhase

Editiert von ahasver am 03.04.2021 22:54

zagent am 03.04.2021 16:00 #15711


Nightly version working GOOD.

Editiert von zagent am 03.04.2021 16:17

Flamefire am 03.04.2021 17:08 #15712


@ahasver: The map cannot be stored in WORLDS as that folder might no be writeable. So we choose the standard folder for saved games which is called "Users/[user]/Saved Games"

---
Github: https://github.com/Flamefire


ahasver am 03.04.2021 22:43 #15713


@Flamefire:
If the in-game generator cannot store in the s25rttr_20210317/WORLDS folder - so be it!
I can't see any reason why it should not be writable during runtime of the generator but afterwards!
Anyway - for S25EDIT it's necessary to have the file to be edited in /WORLDS!

Concerning my MAIN issue I wrote:
So, after shifting the Random.swd to > C:/Spiele/RttR/s25rttr_20210317/WORLDS < and invoking S25EDIT,
the attempt of loading the map was answered by the editor per logfile:
     Loading palette from file: GFX/PALETTE/PAL5.BBM...Error while reading:
     "C:/Spiele/RttR/s25rttr_20210317/WORLDS/Random.swd": Read failed at line 696
This happened independent of map-size (tiny/huge); .swd's of any other provenience were loaded without any issue.

In plain words:
S25EDIT could not load the Random.swd produced by the in-game generator!
My question basically was, if this is a bug in S25EDIT or in Random.swd (intentionally or not) and if this can be fixed.

Best regards

---
28.03.1948 - Osterhase


Flamefire am 05.04.2021 17:09 #15714


The game is usually installed into some system folder which is in general not writable hence we don't assume it ever is and don't write to it (This has become best practice some years ago)

The editor is a bit special: Due to historic reasons it tries the /WORLDS folder first, if that is writable and uses the Saved Games/WORLDS folder otherwise. Maybe we remove the first option in the future to avoid confusion but it is handy if you use the s2edit/S2 and the s25edit in parallel

The maps generated by the ingame map gen were not meant to be edited but simply loaded, so they are not in the WORLDS folder, but you can of course copy those.

I did some changes so you can now load the generated maps in the S2 editor: https://github.com/Return-To-The-Roots/s25client/pull/1407 (needs to be merged)
Before being able to use it in S2 it needs to be resaved in S2edit (the original) to fill in some missing things we can't easily generate.

Hope that helps

---
Github: https://github.com/Flamefire


ahasver am 07.04.2021 22:21 #15715


@Flamefire:
Thank You for Your detailed answer.
As I saw from /pull/1407 You have invested quite some work into this issue - thanks again.
Since I am not familiar with the github - procedures I can only assume that >needs to be merged<
means the changes will show up in the next nightly? Is that correct?

Best regards

---
28.03.1948 - Osterhase


Flamefire am 07.04.2021 22:42 #15716


Once the PR is merged, the changes will shop up in the nightly, see https://github.com/Return-To-The-Roots/s25client/pulls which has tabs for "open" and "closed" PRs

Flow needs to review the PR and merge it, so I can't do that myself (there must be someone else to review ones code)

---
Github: https://github.com/Flamefire




Feel free to post in English!

Antwort schreiben

Username:
Security code:
Text:

   
  Convert smilies like :), ;) etc. into small graphics?
  Convert WWW-addresses into clickable links?
  Soll Boardcode in ihrer Nachricht aktiviert werden?