Hi all!

I'm go to https://www.siedler25.org/index.php?com=dynamic&mod=81
and it's doesn't work;(

---

You could try the in-game map generator. I think the output files are also compatible with the old S2 in case that is your intention :-)
If you're missing any features, let me know!

---

And what do you mean by "doesn't work"? It does work for me at least

---
Github: https://github.com/Flamefire

---

Does not respond to button presses.
It doesn't work at all.
It only worked when I started using a VPN.
Russia doesn't want me to generate maps;)

---

When I press Random map in the game, game crash. And message:

terminate called after throwing an instance of 'std::logic_error'
  what():  Invalid parameters given

---

Doesn't happen here, please use the latest nightly.

---
Github: https://github.com/Flamefire

---

The generator on the portal works fine - period.

LordVader wrote:
You could try the in-game map generator.
I think the output files are also compatible with the old S2 in case that is your intention :-)
If you're missing any features, let me know!

The in-game generator produces very nice HUGE maps (Random.swd) and saves them in:
     C:/Users/Admin/Saved Games/Return To The Roots/MAPS
These maps are executable in s25client - without problems.
BUT:
People tend to modify/improve things they haven't produced themselves.
So, after shifting the Random.swd to > C:/Spiele/RttR/s25rttr_20210317/WORLDS < and invoking S25EDIT,
the attempt of loading the map was answered by the editor per logfile:
     Loading palette from file: GFX/PALETTE/PAL5.BBM...Error while reading:
     "C:/Spiele/RttR/s25rttr_20210317/WORLDS/Random.swd": Read failed at line 696
This happened independent of map-size (tiny/huge); .swd's of any other provenience were loaded without any issue.
So - no compatibility with s25edit, not to speak of S2 / S2EDIT !!
I hope very much this can be fixed! By the way - it would be very convenient,
if the map would be stored directly in WORLDS instead of that odd place UsersAdmin ...

regards

---
28.03.1948 - Osterhase

---

Nightly version working GOOD.

---

@ahasver: The map cannot be stored in WORLDS as that folder might no be writeable. So we choose the standard folder for saved games which is called "Users/[user]/Saved Games"

---
Github: https://github.com/Flamefire

---

@Flamefire:
If the in-game generator cannot store in the s25rttr_20210317/WORLDS folder - so be it!
I can't see any reason why it should not be writable during runtime of the generator but afterwards!
Anyway - for S25EDIT it's necessary to have the file to be edited in /WORLDS!

Concerning my MAIN issue I wrote:
So, after shifting the Random.swd to > C:/Spiele/RttR/s25rttr_20210317/WORLDS < and invoking S25EDIT,
the attempt of loading the map was answered by the editor per logfile:
     Loading palette from file: GFX/PALETTE/PAL5.BBM...Error while reading:
     "C:/Spiele/RttR/s25rttr_20210317/WORLDS/Random.swd": Read failed at line 696
This happened independent of map-size (tiny/huge); .swd's of any other provenience were loaded without any issue.

In plain words:
S25EDIT could not load the Random.swd produced by the in-game generator!
My question basically was, if this is a bug in S25EDIT or in Random.swd (intentionally or not) and if this can be fixed.

Best regards

---
28.03.1948 - Osterhase

---

The game is usually installed into some system folder which is in general not writable hence we don't assume it ever is and don't write to it (This has become best practice some years ago)

The editor is a bit special: Due to historic reasons it tries the /WORLDS folder first, if that is writable and uses the Saved Games/WORLDS folder otherwise. Maybe we remove the first option in the future to avoid confusion but it is handy if you use the s2edit/S2 and the s25edit in parallel

The maps generated by the ingame map gen were not meant to be edited but simply loaded, so they are not in the WORLDS folder, but you can of course copy those.

I did some changes so you can now load the generated maps in the S2 editor: https://github.com/Return-To-The-Roots/s25client/pull/1407 (needs to be merged)
Before being able to use it in S2 it needs to be resaved in S2edit (the original) to fill in some missing things we can't easily generate.

Hope that helps

---
Github: https://github.com/Flamefire

---

@Flamefire:
Thank You for Your detailed answer.
As I saw from /pull/1407 You have invested quite some work into this issue - thanks again.
Since I am not familiar with the github - procedures I can only assume that >needs to be merged<
means the changes will show up in the next nightly? Is that correct?

Best regards

---
28.03.1948 - Osterhase

---

Once the PR is merged, the changes will shop up in the nightly, see https://github.com/Return-To-The-Roots/s25client/pulls which has tabs for "open" and "closed" PRs

Flow needs to review the PR and merge it, so I can't do that myself (there must be someone else to review ones code)

---
Github: https://github.com/Flamefire

---

@Flamefire:
After upgrading to the latest nightly s25edit is loading the random.swd's, very nice!

Maps up to 256x256 are loaded by S2EDIT too, but there were two issues:
When checking the map I was told players 1+2 are in 'invalid' positions.
Pressing the space bar for the construction symbols had no effect!
These showed only up in a limited area after 'brushing' with meadows (for example).
Thus I could 'correct' the positions (which were OK anyway) and save the map.
After reloading the symbols were shown correctly! But as usual with S2EDIT the harbours were gone.
So I tried the somewhat older mapgen 0.91 (Piitinen) and its harbour tool and it worked fine!
Also the old null.exe (Dahmen) was OK (flattens the whole map).

Two questions concerning the generator:
1. It's producing only ONE big continent and the size of the islands cannot be influenced - can this possibly be changed?
2. The pineapples are a nuisance to me  - can't they be treated as normal trees by the woodcutter?

I hope I don't tread your nerves!

Best regards

---
28.03.1948 - Osterhase

---

The invalid and BQ thing is what I meant with "Before being able to use it in S2 it needs to be resaved in S2edit (the original) to fill in some missing things we can't easily generate."

There are options for the map generator, make sure to check those, and more work is in progress
It is possible to make an addon that treats pineapple trees as regular trees, so if you know someone with enough coding expertise to implement this, then there is a good chance. Unfortunately I won't have time for that, as there are too many other things I'd need to work on
Make sure to open an issue on github describing this, just for future reference

---
Github: https://github.com/Flamefire

---

@Flamefire:
Since I am a retired engineer in chemistry and 73 years of age there is definitely no chance
of having any acquaintance to folks in the IT Area who could cope with RttR issues.
Anyway - I appreciate Your kind answers and the bulk of work You are investing.
I followed Your advice and opened an issue on github - maybe somebody is interested.
                                     Spike closed it right away - nice brush off!
Regards

---
28.03.1948 - Osterhase

---

Not meant to simply brush it off, but everything is working as intended. I linked the following addon which should cover your idea, shouldn't it?

https://github.com/Return-To-The-Roots/s25client/issues/921

The idea is simple: Woodcutters can cut down pineapple trees which should be just as good as not spawning them, isn't it?

---

---

Is there any possibility to add new map resolution 384 x 384 ?
For me 256 x 256 is too small and 512 x 512 is too big...

---

@luk3Z: yes, it would be a tiny code change.

Unfortunately, I had a burglary in my flat and my Mac Book got stolen.
Therefore, I can't really help with the required code changes right now.

It should be 3 lines of code (only UI change) in this file:
https://github.com/Return-To-The-Roots/s25client/blob/master/libs/s25main/ingameWindows/iwMapGenerator.cpp#L52

Maybe you find someone who can do those for UI (unless you're developer yourself).

---

In the map generator in the game, I'm missing some settings, that are in the map generator on the site.
Eg, Grain:

But the map generator on the website does not work for me. Even VPN doesn't help now;(

---

It's working for me - do you use something like noScript or whatever these addons are called.

---

---

I tried it on different browsers. Disabled all addons. Nothing helps. Does not work.

https://prnt.sc/26nrbr9

---

Well, as it does work for me it doesn't seem to be a general problem.

Can you check the console output in your browser? maybe an error indicating the problem is shown.

---

---

Spike, thanx bro
fu**ng antivirus block js

---

Glad to hear :)

---

---